Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge libtask_ext upstream #2115

Merged
merged 21 commits into from
Nov 10, 2023
Merged

Merge libtask_ext upstream #2115

merged 21 commits into from
Nov 10, 2023

Conversation

FredericWantiez
Copy link
Member

@FredericWantiez FredericWantiez commented Nov 2, 2023 •
edited by yebai
Loading

Fix #2107; Fix #2105

Close #2119; Close #2120; Close #2121; Close #2122; Close #2123; Close #2124; Close #2125; Close #2126; Close #2127; Close #2128

Breaking change: resume_from has been unified with initial_state; the resume export is removed.

yebai
yebai reviewed Nov 3, 2023
View reviewed changes
Project.toml Outdated Show resolved Hide resolved
@FredericWantiez
Copy link
Member Author

Need to change a few things since we changed the signature of sweep! in between, looks like my master was out of sync.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6828915297

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 14 (0.0%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 0.0%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/mcmc/hmc.jl 0 1 0.0%
src/essential/container.jl 0 3 0.0%
src/mcmc/Inference.jl 0 4 0.0%
src/mcmc/particle_mcmc.jl 0 6 0.0%
Files with Coverage Reduction New Missed Lines %
src/mcmc/particle_mcmc.jl 1 0.0%
Totals Coverage Status
Change from base Build 6732566276: 0.0%
Covered Lines: 0
Relevant Lines: 1435
💛 - Coveralls

@codecov Codecov
Copy link

codecov bot commented Nov 5, 2023 •
edited
Loading

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (4ffe2cd) 0.00% compared to head (55ca37f) 0.00%.
Report is 2 commits behind head on master.

❗ Current head 55ca37f differs from pull request most recent head b7758be. Consider uploading reports for the commit b7758be to get more accurate results

Additional details and impacted files 
@@          Coverage Diff           @@
##           master   #2115   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files          21      21           
  Lines        1451    1450    -1     
======================================
+ Misses       1451    1450    -1
Files Coverage Δ
src/mcmc/Inference.jl 0.00% <0.00%> (ø)
src/mcmc/abstractmcmc.jl 0.00% <0.00%> (ø)
src/mcmc/particle_mcmc.jl 0.00% <0.00%> (ø)
src/essential/container.jl 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FredericWantiez FredericWantiez marked this pull request as ready for review November 5, 2023 10:01
@FredericWantiez FredericWantiez changed the title [WIP] Merge libtask_ext upstream Merge libtask_ext upstream Nov 5, 2023
@FredericWantiez
Copy link
Member Author

I can add a few more tests if needed

@yebai
Copy link
Member

yebai commented Nov 5, 2023

@FredericWantiez sounds good to have a few additional tests.

yebai
yebai reviewed Nov 7, 2023
View reviewed changes
src/essential/container.jl Outdated Show resolved Hide resolved
@yebai
Copy link
Member

yebai commented Nov 7, 2023 •
edited
Loading

Thanks @FredericWantiez -- good work. I left two minor suggestions above.

Re styling: is there a reason for using the 8-space tab in this PR?

@FredericWantiez
Copy link
Member Author

FredericWantiez commented Nov 7, 2023 •
edited
Loading

re: styling. Looks like the IDE messed up everything, I'll change

@FredericWantiez FredericWantiez mentioned this pull request Nov 8, 2023
Merged
@github-actions @yebai
CompatHelper: bump compat for AbstractMCMC to 5, (keep existing compa…
3cd6995 
…t) (#2108)

* CompatHelper: bump compat for AbstractMCMC to 5, (keep existing compat)

* Update Project.toml

* CompatHelper: bump compat for AbstractMCMC to 5 for package test, (keep existing compat) (#2109)

Co-authored-by: CompatHelper Julia <[email protected]>

* Update Project.toml

* CompatHelper: bump compat for AdvancedHMC to 0.6, (keep existing compat) (#2116)

* CompatHelper: add new compat entry for Statistics at version 1, (keep existing compat) (#2112)

* CompatHelper: add new compat entry for Statistics at version 1, (keep existing compat)

* Update Project.toml

---------

Co-authored-by: CompatHelper Julia <[email protected]>
Co-authored-by: Hong Ge <[email protected]>

* CompatHelper: bump compat for AdvancedHMC to 0.6, (keep existing compat)

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: CompatHelper Julia <[email protected]>
Co-authored-by: Hong Ge <[email protected]>

* CompatHelper: bump compat for EllipticalSliceSampling to 2, (keep existing compat) (#2110)

Co-authored-by: CompatHelper Julia <[email protected]>
Co-authored-by: Hong Ge <[email protected]>

* CompatHelper: bump compat for AdvancedMH to 0.8 for package test, (keep existing compat) (#2114)

Co-authored-by: CompatHelper Julia <[email protected]>
Co-authored-by: Hong Ge <[email protected]>

* CompatHelper: bump compat for AdvancedMH to 0.8, (keep existing compat) (#2113)

Co-authored-by: CompatHelper Julia <[email protected]>

---------

Co-authored-by: CompatHelper Julia <[email protected]>
Co-authored-by: Hong Ge <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
yebai
yebai reviewed Nov 9, 2023
View reviewed changes
Project.toml Outdated Show resolved Hide resolved
@yebai
Copy link
Member

yebai commented Nov 10, 2023 •
edited
Loading

We need to unify the resume_from/initial_state interface due to TuringLang/DynamicPPL.jl#551

yebai
yebai approved these changes Nov 10, 2023
View reviewed changes
src/mcmc/hmc.jl Outdated Show resolved Hide resolved
src/mcmc/particle_mcmc.jl Outdated Show resolved Hide resolved
@yebai yebai merged commit d4a7975 into master Nov 10, 2023
6 of 11 checks passed
@yebai yebai deleted the fred/libtask_ext branch November 10, 2023 21:05
This was referenced Jan 7, 2024
Closed
Merged
@torfjelde torfjelde mentioned this pull request Apr 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yebai yebai yebai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FredericWantiez @yebai